feat: add signOut() scope option
#713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent. Was there any discussion about the |
J0
approved these changes
Jul 1, 2023
There was a problem hiding this comment.
LGTM, may want to consider the naming suggestion - another minor reason but no to prefer scope over behaviour is that there's only one spelling of it between UK and US English. In either case, the functionality seems fine to me though so will leave the naming up to you
|
lets go with |
hf
added a commit
to supabase/auth
that referenced
this pull request
Jul 3, 2023
Right now, probably due to a bug, `POST /logout` would log the user out from _all_ sessions they have. This is not always desired behavior. This change adds a new `scope` query param on `/logout` with these values: - `global` (default when not provided) Logs a user out from all sessions they have. - `local` Logs a user out from the current session only. - `others` Logs a user out from all other sessions except the current one. See: - supabase/auth-js#713
hf
force-pushed
the
hf/add-logout-behavior
branch
from
d5c1ba5
to
3619096
Compare
hf
changed the title
signOut() behavior optionsignOut() scope option
|
Changed the name. |
|
🎉 This PR is included in version 2.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
scopeoption to thesignOutmethod which can be used to control which sessions should be signed out of the account.See: