-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add different logout scopes #1112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
force-pushed
the
hf/add-logout-behaviors
branch
2 times, most recently
from
May 20, 2023 09:12
483a9b5
to
867f9f9
Compare
J0
reviewed
May 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think providing more flexibility in terms of logout behavior is a good idea. Thanks for jumping on the ticket!
kangmingtay
previously requested changes
May 22, 2023
hf
force-pushed
the
hf/add-logout-behaviors
branch
from
May 23, 2023 07:28
867f9f9
to
cd99434
Compare
hf
force-pushed
the
hf/add-logout-behaviors
branch
3 times, most recently
from
May 23, 2023 11:04
74ff813
to
32e5311
Compare
hf
force-pushed
the
hf/add-logout-behaviors
branch
from
June 28, 2023 09:23
32e5311
to
8bba754
Compare
hf
force-pushed
the
hf/add-logout-behaviors
branch
from
June 28, 2023 09:41
8bba754
to
c24c703
Compare
J0
approved these changes
Jul 1, 2023
lets name the query param |
kangmingtay
approved these changes
Jul 1, 2023
hf
force-pushed
the
hf/add-logout-behaviors
branch
from
July 3, 2023 07:28
c24c703
to
9a78f9f
Compare
hf
changed the title
feat: add different logout behaviors
feat: add different logout scopes
Jul 3, 2023
🎉 This PR is included in version 2.78.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hf
added a commit
to supabase/auth-js
that referenced
this pull request
Jul 3, 2023
Adds the `behavior` option to the `signOut` method which can be used to control which sessions should be signed out of the account. See: - supabase/auth#1112
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
Right now, probably due to a bug, `POST /logout` would log the user out from _all_ sessions they have. This is not always desired behavior. This change adds a new `scope` query param on `/logout` with these values: - `global` (default when not provided) Logs a user out from all sessions they have. - `local` Logs a user out from the current session only. - `others` Logs a user out from all other sessions except the current one. See: - supabase/auth-js#713
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
Right now, probably due to a bug, `POST /logout` would log the user out from _all_ sessions they have. This is not always desired behavior. This change adds a new `scope` query param on `/logout` with these values: - `global` (default when not provided) Logs a user out from all sessions they have. - `local` Logs a user out from the current session only. - `others` Logs a user out from all other sessions except the current one. See: - supabase/auth-js#713
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
Right now, probably due to a bug, `POST /logout` would log the user out from _all_ sessions they have. This is not always desired behavior. This change adds a new `scope` query param on `/logout` with these values: - `global` (default when not provided) Logs a user out from all sessions they have. - `local` Logs a user out from the current session only. - `others` Logs a user out from all other sessions except the current one. See: - supabase/auth-js#713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, probably due to a bug,
POST /logout
would log the user out from all sessions they have. This is not always desired behavior.This change adds a new
scope
query param on/logout
with these values:global
(default when not provided) Logs a user out from all sessions they have.local
Logs a user out from the current session only.others
Logs a user out from all other sessions except the current one.See:
signOut()
scope option auth-js#713