Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] simplify internal prerender API #5659

Merged
merged 12 commits into from
Jul 21, 2022
Merged

[chore] simplify internal prerender API #5659

merged 12 commits into from
Jul 21, 2022

Conversation

benmccann
Copy link
Member

Remove entries and files from prerender function since they're difficult to construct entities. This will make #5306 much easier to implement

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 747536f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Rich-Harris
Rich-Harris reviewed Jul 21, 2022
View reviewed changes
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's an existing walk utility we can use

packages/kit/src/core/prerender/prerender.js Outdated Show resolved Hide resolved
packages/kit/src/core/prerender/prerender.js Outdated Show resolved Hide resolved
packages/kit/src/core/prerender/prerender.js Outdated Show resolved Hide resolved
@Rich-Harris Rich-Harris merged commit bfac97a into sveltejs:master Jul 21, 2022
@benmccann benmccann deleted the subprocess branch July 21, 2022 23:15
@benmccann benmccann mentioned this pull request Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conduitry Conduitry Conduitry left review comments

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmccann @Rich-Harris @Conduitry