[fix] prerender in subprocess #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 76181e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dominikg
reviewed
Jul 22, 2022
dominikg
reviewed
Jul 22, 2022
dominikg
approved these changes
Jul 22, 2022
Rich-Harris
reviewed
Jul 22, 2022
Rich-Harris
reviewed
Jul 22, 2022
dominikg
approved these changes
Jul 23, 2022
…y up the PR; maybe later
Rich-Harris
reviewed
Jul 25, 2022
Rich-Harris
reviewed
Jul 25, 2022
packages/kit/src/vite/index.js
Outdated
| @@ -318,14 +318,43 @@ function kit() { | |||
| })};\n` | |||
| ); | |||
|
|
|||
| // TODO where is this used? | |||
| process.env.SVELTEKIT_SERVER_BUILD_COMPLETED = 'true'; | |||
There was a problem hiding this comment.
unrelated to this PR, but pretty sure we can get rid of this?
There was a problem hiding this comment.
No objections assuming it's not used anywhere. It was an internal-only thing, so we shouldn't worry about anyone else relying on it
Rich-Harris
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5306
the first half of this was done in #5659. this finishes the job