Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: input css on iOS #23

Merged
merged 1 commit into from
Aug 11, 2020
Merged

fix: input css on iOS #23

merged 1 commit into from
Aug 11, 2020

Conversation

benschac
Copy link
Contributor

Fixed the CSS issue on iOS web browsers where the input knob was off center and there was a system style behind the knob too.

Image 2020-07-17 at 1 51 41 PM

Image 2020-07-17 at 1 43 42 PM

Image 2020-07-17 at 1 49 32 PM

To Test:

  • npm link the PR in site-kit to svlete repo in site folder
  • Run an emulator and then go to localhost. (can use Xcode with a sample iOS app)

If you want to have access to the developer console within safari iOS emulator:

  • Go to safari develop tab --> select simulator.

@benschac
Copy link
Contributor Author

#fixes sveltejs/svelte#5116

@Wolfr Wolfr mentioned this pull request Jul 18, 2020
Closed
@Rich-Harris Rich-Harris merged commit 7b85400 into sveltejs:master Aug 11, 2020
@Rich-Harris
Copy link
Member

thank you! released 1.2.3

@benschac benschac deleted the benjamin-fix-input branch August 11, 2020 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benschac @Rich-Harris