Fixes #5165 REPL on iOS: Input/output toggle is only visible after awk… #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter awkward scroll Signed-off-by: Wolfr <[email protected]>
Wolfr
changed the title
ceifa
approved these changes
Jul 21, 2020
|
Thanks for approving @ceifa! It would be nice to see these changes live. |
antony
approved these changes
Aug 12, 2020
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5165 REPL on iOS: Input/output toggle is only visible after awkward scroll.
By giving
maina height of 100%, we can now treat the.outer-repldiv as a flex container. I removed the absolute positioning from the.input-output-toggleand gave the 3 divs within theouter-repltheir proper flex growth logic:flex: 0(don't grow) for the bars (top bar and bottom bar) andflex: 1;(grow) for the content area.This in turn gives a good scroll result in Safari on iOS13 (tested in simulator).
I then tested for any regressions to the main layout in Firefox, Safari and Chrome and all looked fine.
Signed-off-by: Wolfr [email protected]