[Java][Jersey2] Fix generated Jersey 2 ApiClient to be thread-safe #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the withHttpInfo pattern, consistent with many other generated clients, to return status code and response headers to the caller in a thread-safe way. Refs swagger-api#817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix issue #817
Updated the Jersey 2 ApiClient to use the withHttpInfo pattern, consistent with many other generated clients, to return status code and response headers to the caller in a thread-safe way.
This code is heavily based on a previous PR made to swagger codegen v2: swagger-api/swagger-codegen/#7605
I also noticed a couple of javadoc warnings in relation to ApiClient::updateParamsForAuth so I took the liberty of fixing those.
I've tested this locally and have used the patched swagger codegen jar in another project I'm working on, but if there's anything else needed to verify this fix, please let me know.