Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Jersey2] Make generated client code thread safe #7605

Merged
merged 2 commits into from
Feb 18, 2018

Conversation

tsiq-karold
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR is to make the generated Jersey 2 client thread safe. Currently, the only way to get to response headers and status is by inspecting some fields on the ApiClient which is not thread safe. This PR changes the generated code to follow a similar pattern used by other generated clients with "withHttpInfo" flavours of each method. It is backwards compatibility breaking as it removes the existing header and status fields.

Fixes #7453

cc @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger

… the withHttpInfo pattern used by many other generated clients
… the withHttpInfo pattern used by many other generated clients
Copy link
Contributor

@jeff9finger jeff9finger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Contributor

@jeff9finger jeff9finger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit cddcda0 into swagger-api:master Feb 18, 2018
@wing328
Copy link
Contributor

wing328 commented Feb 18, 2018

@tsiq-karold thanks for the PR. Sorry for the delay in merging this PR into master due to Chinese New Year celebration.

@jeff9finger thanks for reviewing the change.

@wing328 wing328 changed the title Java Jersey2: Make generated client code thread safe [Java][Jersey2] Make generated client code thread safe Feb 18, 2018
@wing328
Copy link
Contributor

wing328 commented Feb 18, 2018

Upgrade Note

The following properties have been removed from ApiClient.java:

-  protected int statusCode;
-  protected Map<String, List<String>> responseHeaders;

To obtain the status code and HTTP headers, please use the additional WithHttpInfo methods instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants