508 fixes #1155
508 fixes #1155
Conversation
Addresses swagger-api#1021 mostly by adding label tags, generating unique element ids as needed. In the process, moved the label text that gets set in the *ContentTypeView.js files to the respective handlebar templates; the text was static as far as I could tell.
|
@mohsen1 is this good to merge? |
|
I don't exactly understand why we're doing this but if it's necessary to have unique identifiers it works for me. |
|
The ids have to be unique per the HTML specification--and the label tags which reference them are there primarily to appease US Federal Government agencies wanting to use Swagger UI. |
Forcing old images to not be CRLF conformed due to new gitattributes file
|
Hi, it looks like we have some merge issues. Can you please rebase? |
add jshint to gulp..lint and dist
fix oauth switch
Addresses swagger-api#1021 mostly by adding label tags, generating unique element ids as needed. In the process, moved the label text that gets set in the *ContentTypeView.js files to the respective handlebar templates; the text was static as far as I could tell.
…her/swagger-ui into develop_2.0-508_compliance
fixes swagger-api#1205, remove dead line
Current code defaults to http protocol, but when package is installed in a https environment, the default validator should be securely available.
Addresses swagger-api#1021 mostly by adding label tags, generating unique element ids as needed. In the process, moved the label text that gets set in the *ContentTypeView.js files to the respective handlebar templates; the text was static as far as I could tell.
Using addApiKeyAuthorization function, needs to be done after swaggerUi is loaded, otherwise calling ``window.swaggerUi.api.clientAuthorizations.add`` will fail, and the authorization headers will not be aded.
…her/swagger-ui into develop_2.0-508_compliance Conflicts: .gitattributes README.md dist/swagger-ui.js dist/swagger-ui.min.js
Addresses swagger-api#1021 mostly by adding label tags, generating unique element ids as needed. In the process, moved the label text that gets set in the *ContentTypeView.js files to the respective handlebar templates; the text was static as far as I could tell.
Using addApiKeyAuthorization function, needs to be done after swaggerUi is loaded, otherwise calling ``window.swaggerUi.api.clientAuthorizations.add`` will fail, and the authorization headers will not be aded.
…her/swagger-ui into develop_2.0-508_compliance Conflicts: .gitattributes dist/swagger-ui.js dist/swagger-ui.min.js src/main/template/param.handlebars src/main/template/param_list.handlebars src/main/template/param_required.handlebars
|
Merge conflicts are gone, but dist/index.html isn't rendering successfully for me ("Uncaught TypeError: undefined is not a function" JS error). Investigating. |
|
After acknowledging how terribly I've screwed up my branch through my git naivete and witnessing the reemergence of merge conflicts, I thought I'd start over: reapply the 508 fixes on top of a fresh copy of the develop_2.0 branch HEAD and make a new pull request. But before I even apply any changes, I find I'm still getting that JS error on render. Please tell me it's not just me with this problem. |
|
Please close this one that I've botched. I've submitted a new PR: #1291 |
|
sure thing |
Addresses #1021 mostly by adding label tags, generating unique element ids as needed.
In the process, moved the label text that gets set in the ___ContentTypeView.js files to the respective handlebar templates; the text was static as far as I could tell.
There are additional minor 508 improvements that can be made with the tables (scope tags, header attributes)