Specialize adjust_storage_size() so it works correctly for cereal::JSONInputArchive.
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would guess that we do need it still ... though if the tests pass I think you're good to go. |
benjamin0
force-pushed
the
ben/size-off-by-2
branch
from
5faf661
to
eae5c6a
Compare
benjamin0
changed the title
adjust_storage_size() so it works correctly for cereal::JSONInputArchive.
benjamin0
force-pushed
the
ben/size-off-by-2
branch
2 times, most recently
from
0ab5782
to
8eddf7a
Compare
|
Awesome looks good. Merge away. If you want to be sure everything will always serialize to binary you could add another test to |
akleeman
approved these changes
Aug 20, 2018
Overload `adjust_storage_size()` so it works correctly for cereal::JSONInputArchive.
benjamin0
force-pushed
the
ben/size-off-by-2
branch
from
8eddf7a
to
cd1f090
Compare
|
closing in favor of #50 |
This was referenced Dec 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to revert this line for the
cereal::BinaryInputArchive()to work. Do we still need it for the JSON archive?