Adds javadoc generator test #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test passed somehow, not needed anymore
silverjam
reviewed
Jul 6, 2022
| @@ -504,6 +504,11 @@ java-examples: | |||
| cd $(SWIFTNAV_ROOT)/java/example && gradle clean fatjar | |||
| $(call announce-end,"Finished building fat jar") | |||
|
|
|||
| javadoc javadocs: | |||
There was a problem hiding this comment.
We could make the dependency of the Java target so that it runs locally-- would there be any downsides to that?
There was a problem hiding this comment.
As in - instead of the additional workflow we just add make javadocs to make java or make test-java when it is locally ran?
Not sure if the make javadocs is necessary overall - just to verify whether there are any errors preventing javadocs built when publishing i.e. #1180 probably not needed since errors should rarely occur(?) so can probably close this PR
There was a problem hiding this comment.
If errors are rare then this is a good place to verify, making everyone check it locally sounds unnecessary
silverjam
approved these changes
Jul 6, 2022
notoriaga
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checks whether javadocs can be built successfully to prevent gradle errors
JIRA Reference
https://swift-nav.atlassian.net/browse/DEVINFRA-807