-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds javadoc generator test #1182
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3bb53af
Updated CHANGELOG
adrian-kong c63ff96
Update benchmark ratios to pass
adrian-kong 2135f40
gitignore gradle
adrian-kong 80e2d05
Delete benchmark_main.py
adrian-kong 48aab61
release alpha
adrian-kong b138a1f
make javascript
adrian-kong 3e04693
adds javadocs generator test
adrian-kong 12ab26d
Merge branch 'adrian/release4.5.0' into adrian/generatejavadocs
adrian-kong 0bfe349
Merge branch 'master' into adrian/generatejavadocs
adrian-kong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could make the dependency of the
Java
target so that it runs locally-- would there be any downsides to that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in - instead of the additional workflow we just add
make javadocs
tomake java
ormake test-java
when it is locally ran?Not sure if the
make javadocs
is necessary overall - just to verify whether there are any errors preventing javadocs built when publishing i.e. #1180 probably not needed since errors should rarely occur(?) so can probably close this PRThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If errors are rare then this is a good place to verify, making everyone check it locally sounds unnecessary