variable length ecdsa signature [GV2-193] #1306
Conversation
There was a problem hiding this comment.
Sorry for changing my mind on this... but every time we try to sneak one of these in we end up regretting it... so maybe we shouldn't try again. One risk is we have already published tooling that will break when it sees the new version of the message -- no new sbp2json has been published for example, but a new rtcm32json has (which now supports decoding SBP) see here: https://github.com/swift-nav/gnss-converters-private/commit/edb13b9e173e933a59d1dcdbe8045b5acaa6e406 (and this was cut after the libsbp submodule was bumped).
notoriaga
force-pushed
the
steve/signing
branch
from
98e837c
to
35a65df
Compare
No worries, I switched to a new message |
| @@ -0,0 +1,1389 @@ | |||
| /* | |||
| * Copyright (C) 2015-2021 Swift Navigation Inc. | |||
There was a problem hiding this comment.
Looks like we might be missing the new test files for C and Java that cover the new message ID.
* Add signature length field to MsgEcdsaSignature Co-authored-by: Jason Mobarak <[email protected]>
* update MSG_ACKNOWLEDGE on demand fields (#1303) * variable length ecdsa signature [GV2-193] (#1306) * Add signature length field to MsgEcdsaSignature Co-authored-by: Jason Mobarak <[email protected]> * fix signature in MsgCertificateChain [GV2-193] (#1307) Co-authored-by: Jason Mobarak <[email protected]> * benchmark: run on consistent machine type Benchmarks seem to oscilate between two values, so attempt to compensate for this by pinning the machine type that things are run on. * python: add framer msg type filter (#1321) * python: add msg type filter To help with speed issues around Python object construction, add an easy means of avoiding work in the Python API. * Update python/sbp/client/framer.py Co-authored-by: Patrick Crumley <[email protected]> * docker: use buster, stretch is archived * python: add unit test for framer filter * python: add unit test for framer message filter --------- Co-authored-by: Patrick Crumley <[email protected]> --------- Co-authored-by: Steven Meyer <[email protected]> Co-authored-by: Jason Mobarak <[email protected]> Co-authored-by: Patrick Crumley <[email protected]>
Description
@swift-nav/devinfra
Makes the signature on MSG_ECDSA_SIGNATURE variable length
API compatibility
This breaks the existing message but it is currently unused
JIRA Reference
https://swift-nav.atlassian.net/browse/GV2-193