Auto submodule update: libsbp - Make the BaseTime inner public (#1332) #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description @swift-nav/devinfra This PR converts the BaseTime tuple struct into an enum with one variant and makes it non_exhaustive. This enables users to access the time inside and makes it similar to how RoverTime can be used. # API compatibility Does this change introduce a API compatibility risk? In general you cannot convert an struct to an enum without it being a breaking change. However, because the enum was a tuple struct with private fields it's constructor was also private, and you cannot create it even with the dot syntax. https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=0369878bb675f5734febf4ad1eebf327 So that means that the chances of this being a breaking change is very small and I feel comfortable marking this as a minor change. If the above is "Yes", please detail the compatibility (or migration) plan: N/A # JIRA Reference would resolve: swift-nav/libsbp#1331 --------- Co-authored-by: Jason Mobarak <[email protected]> Triggered-By: libsbp 25e15c6c7d63c6cdd73cf38f6d6bffd2fe80f84e Upstream-PR: http://github.com/swift-nav/libsbp/pull/1332
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated PR by Jenkins. If CI has passed successfully, merge away!
cmake f4d30717 -> 12b7f037
libsbp 3621e92f -> 25e15c6c
fad0286to4011dab#152) (Auto submodule update: cmake - add FindBoringSSL.cmake (#152) libsbp#1324)165fdafto55a9d4d#147) (5cc9927to48c60ac#146) (Auto submodule update: cmake - Add plantuml [BUILD-537] (#146) libsbp#1296)2105f11to2b1e9a5#129WARNING the following submodules are not consistent
cmake
This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/14266/.