Refactored the lex function in the BlockDirectiveParser file.
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 27, 2023 15:19
…iveParser - Instead of incrementing the take count at every if conditions. We can increment at the end directly. - This make code concise and hence easier to read and debug the while loop.
- Instead of checking for `if` condition to populate the `isQuoted` var, we can directly use the boolean result of `!=` relational operator to populate the variable. - This makes the code concise and more easier to debug and dry-run the while loop.
|
@swift-ci Please test |
QuietMisdreavus
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lexfunction of theTrimmedLine. It's intended to make the code more readable and concise without breaking the existing intended functionality.takeCountvar (within while loop) at every certain conditions, it will update the takeCount only once at the end.ifcondition to populate theisQuotedvar, we can directly use the boolean result of!=relational operator to populate the variable.Testing
I believe this is a minor refactoring and doesn't require any new tests. All the existing test cases was passing. 💯
Checklist
./bin/testscript and it succeededNote