Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored the lex function in the BlockDirectiveParser file. #128

Merged
merged 2 commits into from
May 30, 2023
Merged

Refactored the lex function in the BlockDirectiveParser file. #128

merged 2 commits into from
May 30, 2023

Commits on May 27, 2023

  1. Refactored the lex function of the TrimmedLine in the BlockDirect… 

    …iveParser

- Instead of incrementing the take count at every if conditions. We can increment at the end directly.
- This make code concise and hence easier to read and debug the while loop.
    Mayank committed May 27, 2023
    Configuration menu
    Copy the full SHA
    4078d3a View commit details
    Browse the repository at this point in the history

  2. Removed the if condition to make code more concise. 

    - Instead of checking for `if` condition to populate the `isQuoted` var, we can directly use the boolean result of `!=` relational operator to populate the variable.

- This makes the code concise and more easier to debug and dry-run the while loop.
    Mayank committed May 27, 2023
    Configuration menu
    Copy the full SHA
    ae869c2 View commit details
    Browse the repository at this point in the history