PR update with latest k4geo master branch & adding IDEA DRC simulation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he outgoing beam axis
Co-authored-by: Alvaro Tolosa Delgado <[email protected]>
…hi (key4hep#332) * implement version of ALLEGRO with ECAL barrel with cell corners projective in phi * Update FCCee/ALLEGRO/compact/ALLEGRO_o1_v03/ALLEGRO_o1_v03.xml * add test for ALLEGRO o1 v03 * fix README * improve the comments * add detector construction v03 * updade also other xml files for inclined ecal barrel v03. Improve comments in xml of v02. In cpp of v03 add check that electrode length in xml is consistent with calo r1 r2 and inclination angle * include units in cpp --------- Co-authored-by: Brieuc Francois <[email protected]>
…RC detector constructors, plugins for running simluation with IDEA DRC using ddsim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR update with latest k4geo master branch & adding IDEA DRC simulation