Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have test for xml bundle configuration #5

Closed
dbu opened this issue Jul 3, 2013 · 4 comments
Closed

have test for xml bundle configuration #5

dbu opened this issue Jul 3, 2013 · 4 comments

Comments

@dbu
Copy link
Member

dbu commented Jul 3, 2013

it would be great to have a base test to help with first loading a bundle xml configuration file, then validate it both with the xml schema and the Configuration class to be sure they both expect the same.

@dantleech
Copy link
Member

This is already implemented in the IcTestBundle for Configuration. But this is really easy to do, so I think we can safely just add a base test class here.

@dbu
Copy link
Member Author

dbu commented Jul 3, 2013

in that case would it not be time to integrate IcTestBundle then?

@dantleech
Copy link
Member

The ICBaseTestBundle is really good in terms of features, but there are things about it that I don't like (declaring properties to determine test behavior for example), which I have mentioned in this PR: instaclick/ICBaseTestBundle#28. And of course there is no PHPCR-ODM support, although this might be fixed in a forthcoming Doctrine Fixtures release.

@wouterj
Copy link
Member

wouterj commented Feb 21, 2014

this one is fixed too

@wouterj wouterj closed this as completed Feb 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants