Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xml schema testing #33

Merged
merged 3 commits into from
Dec 27, 2013
Merged

Xml schema testing #33

merged 3 commits into from
Dec 27, 2013

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Dec 21, 2013

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #5
License MIT
Doc PR symfony-cmf/symfony-cmf-docs#335

This PR is the continuation of #9

Instead of using helpers, I used annotations. This results in better error messages. It is also fully tested.

@dantleech
Copy link
Member

looks good! I am OK for this to be merged - although as an aside I have been wondering if we should be creating a repository per testing feature - I quite like that approach with https://github.com/matthiasnoback/SymfonyConfigTest

@wouterj
Copy link
Member Author

wouterj commented Dec 25, 2013

Yeah, I was wondering about that too. The Testing component was first created to bundle all testing tools used by cmf bundles. But now we want to be standalone, we should maybe seperate it.

What do you think of trying to do this for 1.2? We can do some sort of substree split, the same as used for the security component in the core.

@dbu
Copy link
Member

dbu commented Dec 25, 2013

+1 to merge this and think about a splitting or ideally subtree-splitting and necessary refactorings for 1.2

@wouterj
Copy link
Member Author

wouterj commented Dec 27, 2013

OK, I'm merging this now, then we can test all our schema's and make sure they are correct

wouterj added a commit that referenced this pull request Dec 27, 2013
@wouterj wouterj merged commit 4d587c3 into master Dec 27, 2013
@wouterj wouterj deleted the xml_schema_test branch December 27, 2013 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants