[WIP] Added Config Testing Case #27
Conversation
wouterj
commented
Nov 11, 2013
wouterj
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | - |
| Fixed tickets | #23, #9, #5 |
| License | MIT |
| Doc PR | tbd |
| { | ||
| abstract protected function getFilenames(); | ||
| abstract protected function getExpectedResult(); | ||
| abstract protected function getExtension(); |
There was a problem hiding this comment.
these methods are what users implement in their testing code, so i think they really should have phpdoc on expected return values and semantics.
|
assertProcessedConfiguration is part of the symfony base case? looks nice, although i think we should be careful to not use it too much - testing if a yaml array ends up in the expected array is testing the yaml config component rather than the config file. i guess this test is mainly meant to ensure the Configuration.php class is behaving correctly with fixXmlNames and other post-processing things? where we do that, i think its an excellent idea to test that. |
No, it's part of @matthiasnoback's
It should be used once in a bundle, without any other test methods (except for some special cases). It does not test the yaml config component, it tests if the Configuration class matches the expected configuration (yaml, xml and php). It can be used to TDD Configuration classes and to ensure the Configuration class works as expected, without using a functional test. Later on, we can also implement @matthiasnoback's SymfonyDependencyInjectionTest package, to ensure the Extension class does work as expected aswell.
This test is indeed also proofing the support for XML for a bundle. |
|
alright. should this PR then not go against the test of @matthiasnoback directly? this looks very generic to me, not cmf specific at all. i am fully +1 about starting to test the configuration class and ensure xml support, no doubt about that. |
|
I created an issue for that: SymfonyTest/SymfonyConfigTest#3 |
|
btw, to see an example of this, see the RoutingAutoBundle: symfony-cmf/routing-auto-bundle#36 |
|
Okay, @matthiasnoback is going to put this in his library. That means this PR waits till that's done and after that, it can be merged with some tweaks. |
|
closing this. It's now merged into the SymfonyDependencyInjectionTest library of @matthiasnoback. See symfony-cmf/routing-auto-bundle#38 for an example how to implement this. |
