use the ref role for internal links #20053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jul 19, 2024
| controller, such as `value resolvers`_, and even to change the controller | ||
| entirely:: | ||
| controller, such as :ref:`value resolvers <managing-value-resolvers>`, and | ||
| even to change the controller entirely:: |
There was a problem hiding this comment.
@alamirault we could add a DOCtor-RST rule which is configurable and checks that links to https://symfony.com/doc..... should not be allowed to avoid further issues like that
There was a problem hiding this comment.
Such a check would still have to skip links to third-party bundle docs that are hosted on symfony.com.
There was a problem hiding this comment.
yes, should be configurable for that
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.