Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the ref role for internal links #20053

Merged
merged 1 commit into from
Jul 19, 2024
Merged

use the ref role for internal links #20053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions reference/events.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ their priorities:

This event is dispatched after the controller has been resolved but before executing
it. It's useful to initialize things later needed by the
controller, such as `value resolvers`_, and even to change the controller
entirely::
controller, such as :ref:`value resolvers <managing-value-resolvers>`, and
even to change the controller entirely::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamirault we could add a DOCtor-RST rule which is configurable and checks that links to https://symfony.com/doc..... should not be allowed to avoid further issues like that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a check would still have to skip links to third-party bundle docs that are hosted on symfony.com.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, should be configurable for that


use Symfony\Component\HttpKernel\Event\ControllerEvent;

Expand Down Expand Up @@ -296,5 +296,3 @@ their priorities:
.. code-block:: terminal

$ php bin/console debug:event-dispatcher kernel.exception

.. _`value resolvers`: https://symfony.com/doc/current/controller/value_resolver.html#managing-value-resolvers
Loading