Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TwigComponent] Deprecate cva twig function #2144

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[TwigComponent] Deprecate cva twig function #2144

merged 1 commit into from
Sep 11, 2024

Conversation

Kocal
Copy link
Collaborator

@Kocal Kocal commented Sep 10, 2024 •
edited
Loading

Q A
Bug fix? no
New feature? no
Issues Fix #2070
License MIT

Use the new Twig\DeprecatedCallableInfo added in twigphp/Twig#4291, it help us to specify the package where the alternative can be found, which was not the case before.

@Kocal Kocal force-pushed the 2070-deprecate-cva branch 4 times, most recently from fc818a7 to aef3567 Compare September 10, 2024 06:52
@Kocal Kocal marked this pull request as draft September 10, 2024 06:53
@Kocal Kocal force-pushed the 2070-deprecate-cva branch 3 times, most recently from 9584764 to 1f58821 Compare September 10, 2024 07:17
@Kocal Kocal marked this pull request as ready for review September 10, 2024 07:17
@Kocal Kocal mentioned this pull request Sep 10, 2024
Merged
@Kocal Kocal force-pushed the 2070-deprecate-cva branch 3 times, most recently from 88c7f6a to 2271248 Compare September 10, 2024 21:22
smnandre
smnandre approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Let's update the src/TwigComponent/CHANGELOG too if you have time)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 10, 2024
@Kocal Kocal force-pushed the 2070-deprecate-cva branch 4 times, most recently from 2f2d76c to a872e53 Compare September 11, 2024 06:54
@Kocal Kocal merged commit e22484b into symfony:2.x Sep 11, 2024
42 checks passed
@Kocal Kocal deleted the 2070-deprecate-cva branch September 11, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TwigComponent] Cva in html_extra
3 participants
@Kocal @smnandre @carsonbot