Improve the way one can deprecate a Twig callable #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
deprecated-as-object
branch
from
a834e47
to
a1252c6
Compare
nicolas-grekas
approved these changes
Sep 9, 2024
stof
reviewed
Sep 9, 2024
fabpot
force-pushed
the
deprecated-as-object
branch
2 times, most recently
from
0eb6e9c
to
d6656c9
Compare
stof
reviewed
Sep 9, 2024
fabpot
force-pushed
the
deprecated-as-object
branch
2 times, most recently
from
9ac2898
to
813e932
Compare
GromNaN
reviewed
Sep 9, 2024
fabpot
force-pushed
the
deprecated-as-object
branch
from
813e932
to
94dd2af
Compare
fabpot
force-pushed
the
deprecated-as-object
branch
from
94dd2af
to
34ae031
Compare
Kocal
added a commit
to symfony/ux
that referenced
this pull request
Sep 11, 2024
This PR was merged into the 2.x branch. Discussion ---------- [TwigComponent] Deprecate `cva` twig function | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #2070 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Use the new `Twig\DeprecatedCallableInfo` added in twigphp/Twig#4291, it help us to specify the package where the alternative can be found, which was not the case before. Commits ------- e310074 [TwigComponent] Deprecate `cva` twig function
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Sep 12, 2024
…es if possible (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [TwigBridge] use DeprecatedCallableInfo for Twig callables if possible | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT see twigphp/Twig#4291 Commits ------- 76e80d7 use DeprecatedCallableInfo for Twig callables if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.