Drafting mysql_hostgroup_attributes #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some rework to try to reduce duplicated code
In Admin: - replaced a lot of flush_[...]__from_memory_to_disk() and flush_[...]__from_disk_to_memory() with a generic flush_GENERIC__from_to() - several commands like "LOAD MYSQL SERVERS FROM DISK" and similar are automatically generated for various modules (not all) and saved/map in a map load_save_disk_commands - FlushCommandWrapper() is able to map the various LOAD/SAVE from/to DISK into commands to run on SQLite
|
retest this please |
1 similar comment
|
retest this please |
This commit adds some minimal testing for mysql_hostgroup_attributes . It helped detecting some bugs.
Fixes: * minor memory leak when running CHECKSUM command * minor memory leak in load_mysql_servers_to_runtime() * not initialized json in MySQL_Event (valgrind doesn't like it) * not initialized variable MySQL_Thread::shutdown in the constructor
If mysql_hostgroup_attributes.multiplex: - 0 : multiplexing is always disabled - 1 : multiplexing is enabled for the hostgroup, but other criteria can disable multiplexing (transaction, temp tables, query rules, etc)
Implementation of mysql_hostgroup_attributes.free_connections_pct and mysql_hostgroup_attributes.connection_warming If mysql_hostgroup_attributes is configured: - mysql_hostgroup_attributes.free_connections_pct has higher priority than global variable mysql-free_connections_pct - mysql_hostgroup_attributes.connection_warming has higher priority than global variable mysql-connection_warming
Implementation of mysql_hostgroup_attributes.throttle_connections_per_sec If mysql_hostgroup_attributes is configured, mysql_hostgroup_attributes.throttle_connections_per_sec has higher priority than global variable mysql-throttle_connections_per_sec_to_hostgroup
|
retest this please |
1 similar comment
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #4078