Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drafting mysql_hostgroup_attributes #4091

Merged
merged 13 commits into from
Jan 31, 2023

Commits on Jan 11, 2023

  1. Removing commented code

    renecannao committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    5fc840b View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Code cleanup on MySQL_HostGroups_Manager

    Some rework to try to reduce duplicated code
    renecannao committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    71e2510 View commit details
    Browse the repository at this point in the history
  2. Fix compiling

    renecannao committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    107a864 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Several code improvements

    In Admin:
    - replaced a lot of flush_[...]__from_memory_to_disk() and flush_[...]__from_disk_to_memory() with a generic flush_GENERIC__from_to()
    - several commands like "LOAD MYSQL SERVERS FROM DISK" and similar are automatically generated for various modules (not all) and saved/map in a map load_save_disk_commands
    - FlushCommandWrapper() is able to map the various LOAD/SAVE from/to DISK into commands to run on SQLite
    renecannao committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    36575d2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ceb5695 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7e382f0 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Fixing 2 typos

    renecannao committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    23a36ee View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. Configuration menu
    Copy the full SHA
    d61c043 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2023

  1. Added 1st testing for mysql_hostgroup_attributes

    This commit adds some minimal testing for mysql_hostgroup_attributes .
    It helped detecting some bugs.
    renecannao committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    9235fbf View commit details
    Browse the repository at this point in the history
  2. Various minor fixes

    Fixes:
    * minor memory leak when running CHECKSUM command
    * minor memory leak in load_mysql_servers_to_runtime()
    * not initialized json in MySQL_Event (valgrind doesn't like it)
    * not initialized variable MySQL_Thread::shutdown in the constructor
    renecannao committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    3837de6 View commit details
    Browse the repository at this point in the history
  3. Implemented mysql_hostgroup_attributes.multiplex

    If mysql_hostgroup_attributes.multiplex:
    - 0 : multiplexing is always disabled
    - 1 : multiplexing is enabled for the hostgroup, but other criteria can disable multiplexing (transaction, temp tables, query rules, etc)
    renecannao committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    f3c604e View commit details
    Browse the repository at this point in the history
  4. mysql_hostgroup_attributes free_connections_pct and connection_warming

    Implementation of mysql_hostgroup_attributes.free_connections_pct and mysql_hostgroup_attributes.connection_warming
    
    If mysql_hostgroup_attributes is configured:
    - mysql_hostgroup_attributes.free_connections_pct has higher priority than global variable mysql-free_connections_pct
    - mysql_hostgroup_attributes.connection_warming has higher priority than global variable mysql-connection_warming
    renecannao committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    7b00d05 View commit details
    Browse the repository at this point in the history
  5. mysql_hostgroup_attributes.throttle_connections_per_sec

    Implementation of mysql_hostgroup_attributes.throttle_connections_per_sec
    
    If mysql_hostgroup_attributes is configured,
    mysql_hostgroup_attributes.throttle_connections_per_sec has higher
    priority than global variable mysql-throttle_connections_per_sec_to_hostgroup
    renecannao committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    dcf9a4a View commit details
    Browse the repository at this point in the history