Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset multiple to first cursor's position #1097

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

trkoch
Copy link

@trkoch trkoch commented Sep 21, 2018

Respect first cursor's position when clearing multiple cursors.
Previously the last added cursor's position was used. By reversing the
logic clearing now more closely matches the behavior found in default
Atom.

Closes #899.

@trkoch
Copy link
Author

trkoch commented Sep 22, 2018

Reverted to default behavior, introduced option.

@trkoch
Copy link
Author

trkoch commented Sep 22, 2018

Does seem to break resetting from occurrence with clearMultipleCursorsOnEscapeInsertMode. cop <some text> esc resets to second occurrence (not first, as expected).

@trkoch
Copy link
Author

trkoch commented Jan 24, 2019

What's the status here? Can I do something?

Respect first cursor's position when clearing multiple cursors.
Previously the last added cursor's position was used. By reversing the
logic clearing now more closely matches the behavior found in default
Atom.
* By default clear to last position (previous behavior)
* When enabled always clear to first position (includes undo)
Conditionally skip workaround involving positioning of popups
at proper position. Previously with `clearMultipleCursorsToFirstPosition`
enabled, and using occurence, it would clear to second instead
of first position.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

last cursor position not preserved when clearMultipleCursorsOnEscapeInsertMode is true
1 participant