Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset multiple to first cursor's position #1097

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Reset multiple to first cursor's position #1097

wants to merge 4 commits into from
+36 −4

Commits on Jan 24, 2019

  1. Reset multiple to first cursor's position 

    Respect first cursor's position when clearing multiple cursors.
Previously the last added cursor's position was used. By reversing the
logic clearing now more closely matches the behavior found in default
Atom.
    @trkoch
    trkoch committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    a2ec4a5 View commit details
    Browse the repository at this point in the history

  2. Introduce clearMultipleCursorsToFirstPosition setting 

    * By default clear to last position (previous behavior)
* When enabled always clear to first position (includes undo)
    @trkoch
    trkoch committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    e8c4754 View commit details
    Browse the repository at this point in the history

  3. Remove unused parameter

    @trkoch
    trkoch committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    0a48aeb View commit details
    Browse the repository at this point in the history

  4. Workaround clearing to first when using occurence 

    Conditionally skip workaround involving positioning of popups
at proper position. Previously with `clearMultipleCursorsToFirstPosition`
enabled, and using occurence, it would clear to second instead
of first position.
    @trkoch
    trkoch committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    d86144d View commit details
    Browse the repository at this point in the history