Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable --preserve-paths without --copy-attachments #68

Closed
tagatac opened this issue Sep 14, 2024 · 0 comments · Fixed by #69
Closed

Disable --preserve-paths without --copy-attachments #68

tagatac opened this issue Sep 14, 2024 · 0 comments · Fixed by #69
Labels
enhancement New feature or request

Comments

@tagatac
Copy link
Owner

tagatac commented Sep 14, 2024

The --preserve-paths flag doesn't make any sense without the --copy-attachments flag.

Originally posted by @tagatac in #63 (comment)
@tagatac tagatac added the enhancement New feature or request label Sep 14, 2024
@tagatac tagatac mentioned this issue Sep 14, 2024
Merged
tagatac added a commit that referenced this issue Sep 14, 2024
@tagatac
Add option validation (#69)
5d9665a 
**What is changing**: Add checks that nonsensical combinations of flags
are not used.

**Why this change is being made**:
1. To avoid letting users perform long exports only to learn that one of
the flags they used was unexpectedly ignored.
2. To avoid performing functions in unexpected situations, e.g. creating
a tilde expansion file when there are no copied attachments.

**Related issue(s)**: Closes #68 

**Follow-up changes needed**: None

**Is the change completely covered by unit tests? If not, why not?**:
Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option validation tagatac/bagoup
1 participant
@tagatac