Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option validation #69

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Add option validation #69

merged 1 commit into from
Sep 14, 2024

Conversation

tagatac
Copy link
Owner

@tagatac tagatac commented Sep 14, 2024

What is changing: Add checks that nonsensical combinations of flags are not used.

Why this change is being made:

  1. To avoid letting users perform long exports only to learn that one of the flags they used was unexpectedly ignored.
  2. To avoid performing functions in unexpected situations, e.g. creating a tilde expansion file when there are no copied attachments.

Related issue(s): Closes #68

Follow-up changes needed: None

Is the change completely covered by unit tests? If not, why not?: Yes

@tagatac tagatac merged commit 5d9665a into main Sep 14, 2024
3 of 4 checks passed
@tagatac tagatac deleted the validate-opts branch September 14, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable --preserve-paths without --copy-attachments
1 participant