-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lang] Instantiate a runtime ArgPack object when a python ArgPack is created #8241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…created [ghstack-poisoned]
This was referenced Jun 28, 2023
listerily
added a commit
that referenced
this pull request
Jun 28, 2023
…created ghstack-source-id: d1dc8a846ff1202b84fc47c270d0e88e7dabeca3 Pull Request resolved: #8241
for more information, see https://pre-commit.ci
…ArgPack is created" [ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jul 3, 2023
…created ghstack-source-id: 29844f37722793bb8057710eb0abe55209c2e92e Pull Request resolved: #8241
for more information, see https://pre-commit.ci
…ArgPack is created" [ghstack-poisoned]
listerily
added a commit
that referenced
this pull request
Jul 3, 2023
…created ghstack-source-id: 9bb67afc51c41ea3f69d893d7c56240fcf09841b Pull Request resolved: #8241
This was referenced Jul 4, 2023
Merged
…ArgPack is created" [ghstack-poisoned]
for more information, see https://pre-commit.ci
…ArgPack is created" [ghstack-poisoned]
…ArgPack is created" [ghstack-poisoned]
lin-hitonami
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
taichi-gardener
pushed a commit
that referenced
this pull request
Jul 11, 2023
…created ghstack-source-id: e0bde13e0ea7ad3d13fec46a8d776e3815745c56 Pull Request resolved: #8241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):