New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lang] Argpacks stores scalar values only in cpp implementation, and passes ndarray values by 'virtual parameters' #8266

Closed

listerily wants to merge 13 commits into gh/listerily/16/base from gh/listerily/16/head

Contributor

listerily commented Jul 7, 2023 •

edited

Loading

Stack from ghstack (oldest at bottom):


          [lang] Argpacks stores scalar values only in cpp implementation, and …

3178c6a

…passes ndarray values by 'virtual parameters'

[ghstack-poisoned]

This was referenced Jul 7, 2023

[refactor] Add base class GfxProgramImpl #8179

Closed

[refactor] Make arg_id a vector #8204

Merged

[refactor] Enhance argument data structures, replacing vector styled arguments with nestable styled arguments #8216

Merged

[lang] Add cpp impl of ArgPackType #8176

Merged

[lang] Link cpp ArgPackType object to python ArgPackType #8178

Merged

[refactor] Renamed allocate_memory_ndarray to allocate_memory_on_device #8240

Merged

[lang] Instantiate a runtime ArgPack object when a python ArgPack is created #8241

Merged

[lang] Add set_arg methods to ArgPack and pass scalar values to ArgPack buffer #8255

Merged

[bug] Fix indexing crash in TaskCodeGenLLVM::get_struct_arg #8256

Merged

[lang] Add is_argpack property to Argument and pass argpack ptrs to LaunchContextBuilder #8257

Merged

This was referenced Jul 7, 2023

[lang] Add arg_depth property to Expressions and Statements #8259

Merged

[Bug] Convert matrices to structs in argpack type members, Fixing layout error #8262

Merged

[spirv] [ir] Support argpack buffer load for spir-v backends #8263

Merged

[Bug] Fix argpack nesting issues #8264

Merged

[test] Recover skipped argpack tests (spir-v backends only) #8265

Merged

listerily added a commit that referenced this pull request


          [lang] Argpacks stores scalar values only in cpp implementation, and …

a0b3d31

…passes ndarray values by 'virtual parameters'

ghstack-source-id: d59cb7110531f92dfeaf5d5e4a8710d4f0b1852e
Pull Request resolved: #8266

pre-commit-ci bot and others added 2 commits

July 7, 2023 09:01


          [pre-commit.ci] auto fixes from pre-commit.com hooks

e874c66

for more information, see https://pre-commit.ci


          Update on "[lang] Argpacks stores scalar values only in cpp implement…

2ec9efc

…ation, and passes ndarray values by 'virtual parameters'"

[ghstack-poisoned]

listerily added a commit that referenced this pull request


          [lang] Argpacks stores scalar values only in cpp implementation, and …

6437bb9

…passes ndarray values by 'virtual parameters'

ghstack-source-id: 716ff0e9f5a5db505d82c4b1dc04dd7719889102
Pull Request resolved: #8266

pre-commit-ci bot and others added 2 commits

July 7, 2023 12:19


          [pre-commit.ci] auto fixes from pre-commit.com hooks

21077c1

for more information, see https://pre-commit.ci


          Update on "[lang] Argpacks stores scalar values only in cpp implement…

…ation, and passes ndarray values by 'virtual parameters'"

[ghstack-poisoned]

listerily added a commit that referenced this pull request


          [lang] Argpacks stores scalar values only in cpp implementation, and …

0b4766b

…passes ndarray values by 'virtual parameters'

ghstack-source-id: de47f512589bbb8629e14d2f78fedc196e2f3e71
Pull Request resolved: #8266


          Update on "[lang] Argpacks stores scalar values only in cpp implement…

30c8cd2

…ation, and passes ndarray values by 'virtual parameters'"

[ghstack-poisoned]

listerily added a commit that referenced this pull request


          [lang] Argpacks stores scalar values only in cpp implementation, and …

…passes ndarray values by 'virtual parameters'

ghstack-source-id: 58da08f1c34c20ad291d0d044fce9616bfdef8cc
Pull Request resolved: #8266

pre-commit-ci bot and others added 2 commits

July 7, 2023 12:45


          [pre-commit.ci] auto fixes from pre-commit.com hooks

da708d3

for more information, see https://pre-commit.ci


          Update on "[lang] Argpacks stores scalar values only in cpp implement…

b0b72cd

…ation, and passes ndarray values by 'virtual parameters'"

[ghstack-poisoned]

listerily added a commit that referenced this pull request


          [lang] Argpacks stores scalar values only in cpp implementation, and …

a08d945

…passes ndarray values by 'virtual parameters'

ghstack-source-id: d1d8582deadb1e4aa78903266b30fc475e76b9b0
Pull Request resolved: #8266


          Update on "[lang] Argpacks stores scalar values only in cpp implement…

2797f8e

…ation, and passes ndarray values by 'virtual parameters'"

[ghstack-poisoned]

listerily added a commit that referenced this pull request


          [lang] Argpacks stores scalar values only in cpp implementation, and …

0ceb9b1

…passes ndarray values by 'virtual parameters'

ghstack-source-id: 246b80b5654721130007fc3f6f7e35667daa0ced
Pull Request resolved: #8266

This was referenced Jul 9, 2023

[llvm] [ir] Implemented argpack buffer load on llvm devices #8267

Closed

[refactor] Renamed 'get_ndarray_alloc_info_ptr' to 'get_device_alloc_info_ptr' #8268

Closed

listerily and others added 4 commits

July 10, 2023 13:34


          Update on "[lang] Argpacks stores scalar values only in cpp implement…

ec5b875

…ation, and passes ndarray values by 'virtual parameters'"

[ghstack-poisoned]


          [pre-commit.ci] auto fixes from pre-commit.com hooks

fb38110

for more information, see https://pre-commit.ci


          Update on "[lang] Argpacks stores scalar values only in cpp implement…

06278fc

…ation, and passes ndarray values by 'virtual parameters'"

[ghstack-poisoned]


          Update on "[lang] Argpacks stores scalar values only in cpp implement…

e64fe11

…ation, and passes ndarray values by 'virtual parameters'"

[ghstack-poisoned]

listerily mentioned this pull request

[lang] [ir] Support argpack nesting #8273

Closed

lin-hitonami approved these changes

View reviewed changes

taichi-gardener deleted the gh/listerily/16/head branch

July 12, 2023 14:33

taichi-gardener closed this in

14e83c4

listerily mentioned this pull request

[RFC] Argument pack API #5662

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet