Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source formatting #13

Closed
cstamas opened this issue Mar 3, 2023 · 0 comments · Fixed by #17
Closed

Source formatting #13

cstamas opened this issue Mar 3, 2023 · 0 comments · Fixed by #17
Assignees
@cstamas

Comments

@cstamas
Copy link
Member

cstamas commented Mar 3, 2023

We need some source formatting tool, maybe similarly implemented as in Maven (starting with 3.9+), using spotless, where check is part of build, and users case just apply before commit.
@cstamas cstamas self-assigned this Mar 3, 2023
@cstamas cstamas mentioned this issue Feb 9, 2024
Merged
cstamas added a commit that referenced this issue Feb 9, 2024
@cstamas
Apply spotless (#17)
0674a89 
Pretty much same scheme as in Maven project:
* check runs in build and will fail it if not properly formatted
* mvn spotless:apply to format (or -P format)

Fixes #13

Due spotless plugin (does not run on Java8) the "build time Java requirement" raises to Java 11, but IMHO this is not a problem as we already build most of the projects with it.

---

Applying this parent in project will need 3 steps:
* PR to change parent version (build will fail due formatting)
* subsequent commit where developer runs `mvn spotless:apply` and pushes (build will pass)
* subsequent commit to repository root into file `.git-blame-ignore-revs` with commit hash from 2nd commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cstamas cstamas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply spotless takari/takari-pom
1 participant
@cstamas