Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply spotless #17

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Apply spotless #17

merged 8 commits into from
Feb 9, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Feb 9, 2024

Pretty much same scheme as in Maven project:

  • check runs in build and will fail it if not properly formatted
  • mvn spotless:apply to format (or -P format)

Fixes #13

Due spotless plugin (does not run on Java8) the "build time Java requirement" raises to Java 11, but IMHO this is not a problem as we already build most of the projects with it.


Applying this parent in project will need 3 steps:

  • PR to change parent version (build will fail due formatting)
  • subsequent commit where developer runs mvn spotless:apply and pushes (build will pass)
  • subsequent commit to repository root into file .git-blame-ignore-revs with commit hash from 2nd commit

@cstamas cstamas self-assigned this Feb 9, 2024
Pretty much same scheme as in Maven project:
* check runs in build and will fail it if not properly formatted
* mvn spotless:apply to format (or -P format)
@cstamas cstamas merged commit 0674a89 into master Feb 9, 2024
1 check passed
@cstamas cstamas deleted the apply-spotless branch February 9, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source formatting
1 participant