Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issue ("_numYearsN_") in DayFromYear #3180

Closed
linusg opened this issue Sep 21, 2023 · 1 comment · Fixed by #3203
Closed

Rendering issue ("_numYearsN_") in DayFromYear #3180

linusg opened this issue Sep 21, 2023 · 1 comment · Fixed by #3203

Comments

@linusg
Copy link
Member

linusg commented Sep 21, 2023

This is tricky as it tries to refer to multiple similarly named variables, but the result of mixing inline code and variable syntax looks rather odd:

`_numYearsN_`

I think this should use plain code without the underscores, or the variable syntax (which would emit warning: could not find a preceding declaration for "numYearsN" (use-before-def))

image

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Sep 21, 2023
@jmdyck
Copy link
Collaborator

jmdyck commented Sep 21, 2023

That's my fault, back in PR #3092. (Didn't look close enough at the rendering.) I'll submit a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants