Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Fix formatting of note-step in DayFromYear #3183

Closed
wants to merge 1 commit into from
Closed

Editorial: Fix formatting of note-step in DayFromYear #3183

wants to merge 1 commit into from
+1 −1

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Sep 21, 2023

Fixes #3180.

@jmdyck
Copy link
Collaborator Author

jmdyck commented Sep 21, 2023

Link to DayFromYear in new rendering

linusg
linusg approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see there's functionality to do this cleanly!

@michaelficarra michaelficarra mentioned this pull request Oct 18, 2023
Merged
@ljharb ljharb closed this in #3203 Jan 25, 2024
@jmdyck jmdyck deleted the DayFromYear branch January 25, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syg syg syg approved these changes

@bakkot bakkot bakkot approved these changes

@linusg linusg linusg approved these changes

Assignees
No one assigned
Labels
editorial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rendering issue ("_numYearsN_") in DayFromYear
4 participants
@jmdyck @syg @bakkot @linusg