Editorial: Object Environment Record improvements #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also resolves this comment from @michaelficarra in PR #1697. |
bakkot
reviewed
Jan 23, 2021
bakkot
reviewed
Jan 23, 2021
bakkot
approved these changes
Jan 23, 2021
jmdyck
force-pushed
the
object_Env_Rec
branch
from
d31bf01
to
8357ba3
Compare
|
(force-pushed because I forgot to note that NewObjectEnvironment's |
ExE-Boss
reviewed
Jan 25, 2021
jmdyck
force-pushed
the
object_Env_Rec
branch
from
8357ba3
to
7c24e5d
Compare
|
force-pushed to:
|
annevk
reviewed
Feb 4, 2021
jmdyck
force-pushed
the
object_Env_Rec
branch
from
7c24e5d
to
786c5d2
Compare
|
force-pushed to:
|
michaelficarra
approved these changes
Feb 12, 2021
syg
approved these changes
Mar 17, 2021
bakkot
added
ready to merge
…9#2287) ... rather than creating "a new object Environment Record" directly. (Now, all object Environment Records are created via NewObjectEnvironment.)
... when creating an object Environment Record. (So _withEnvironment_ no longer needs to have a "default" value.)
... that gives the value for the new environment's _withEnvironment_ flag.
Specifically: [[BindingObject]] and [[IsWithEnvironment]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2285.
The first 3 commits (which could be squashed before merging) add a parameter to
NewObjectEnvironmentthat supplies the value for the new environment's withEnvironment flag, as suggested in whatwg PR 6086. The HTML spec has 3 calls toNewObjectEnvironmentthat would need to add an argument.The 4th commit introduces fields
[[BindingObject]]and[[WithEnvironmentFlag]]where formerly algorithms would refer tothe binding object for _envRec_andthe _withEnvironment_ flag of _envRec_respectively.The 5th commit just renames
_bindings_to_bindingObject_when it receives a[[BindingObject]].