Editorial: Have NewGlobalEnvironment invoke NewDeclarativeEnvironment #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Sep 5, 2022
michaelficarra
approved these changes
Sep 6, 2022
syg
approved these changes
Sep 28, 2022
syg
added
the
ready to merge
In NewDeclarativeEnvironment, allow parameter `_E_` to be `*null*`, and in NewGlobalEnvironment, change `a new declarative Environment Record containing no bindings` to `NewDeclarativeEnvironment(*null*)`
ljharb
force-pushed
the
NewDeclarativeEnvironment
branch
from
8ae38ce
to
1376165
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NewDeclarativeEnvironment, allow parameter
_E_to be*null*,and in NewGlobalEnvironment, change
a new declarative Environment Record containing no bindingsto
NewDeclarativeEnvironment(*null*)History:
NewDeclarativeEnvironment(*null*)used to have different semantics, which would have been wrong for NewGlobalEnvironment, so the latter useda new declarative Environment Record containing no bindingsinstead. But the merge of PR #1697 changed the semantics of NewDeclarativeEnvironment, and now it makes sense for NewGlobalEnvironment to call it.The first commit in PR #2287 did something analogous for NewObjectEnvironment and NewGlobalEnvironment's call to it.
(prompted by engine262/engine262#166)