Feature: Add toJSON so that Signal.State (no matter where it exists in a bigger structure) behaves well with JSON.stringify #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorvell
reviewed
Apr 9, 2024
NullVoxPopuli
commented
Apr 9, 2024
| @@ -188,7 +204,7 @@ describe("Watcher", () => { | |||
| // Adding any other effect after an unwatch should work as expected | |||
| const destructor2 = effect(() => { | |||
| output = stateSignal.get(); | |||
| return () => {}; | |||
| return () => { }; | |||
There was a problem hiding this comment.
apologies -- my prettier plugin considers the existence of package.json as "when to enable prettier" :(
I've opened this as well: #163
littledan
requested changes
Apr 9, 2024
|
I've reasoned here why this is a terrible idea if the subscription happens out of the box: #164 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title.
Idk if folks would want more information included, but I think this makes sense -- it's a reactive version of a value, and this toJSON implementation essentially just unwraps that which JSON doesn't care about