Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prettier so folks' editors (maybe just me? 😅 ) don't reformat things differently on save -- should help focus changes in PRs #163

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add prettier so folks' editors (maybe just me? 😅 ) don't reformat things differently on save -- should help focus changes in PRs #163

wants to merge 2 commits into from

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Apr 9, 2024 •
edited
Loading

title.

I'm mostly using defaults, but can change to whatever

@NullVoxPopuli NullVoxPopuli changed the title Add prettier so folks' editors (maybe just me? 😅 ) don't reformat things on save -- should help focus changes in PRs Add prettier so folks' editors (maybe just me? 😅 ) don't reformat things differently on save -- should help focus changes in PRs Apr 9, 2024
@NullVoxPopuli NullVoxPopuli mentioned this pull request Apr 9, 2024
Closed
littledan
littledan requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@littledan littledan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude the Angular code from reformatting (or bring in their linter settings) so that it's easier to merge back in. Maybe this would be easier if the Angular code were in a separate directory.

@NullVoxPopuli
Copy link
Collaborator Author

sure thing, where is the angular code from?

@littledan
Copy link
Member

https://github.com/angular/angular/tree/main/packages/core/primitives/signals/src

@koiralakiran1
Copy link

Do you think it would be beneficial to add something like lint-staged + husky in addition to just prettier? I'd be happy to make the change if required.

@NullVoxPopuli
Copy link
Collaborator Author

I do not, as husky can caused irreversible lost work if you ctrl+c twice while it's running

@PatrickJS PatrickJS mentioned this pull request Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledan littledan littledan requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NullVoxPopuli @littledan @koiralakiran1