refactor(wrapper.ts) format and style #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we’re making these style fixes, do you want to set this up with some config files/CI so it is more sustainable than manual application? |
|
yup I can set that up 👍 any preference? I'm thinking github actions eslint and prettier config |
|
My main preference is, leave the files which are forked from Angular as they are format-wise, to make it easier to later synchronize with them. Other than that, as long as we have semicolons, I am good with whatever style choice. |
fix spacing const rather than let type ``` const ref = this[NODE]; return signalGetFn.call<SignalNode<T>, [], T>(ref); ``` from ``` return signalGetFn<T>.call(this[NODE]); ```
|
I'll get to this this weekend 👍 |
|
closing for #163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix spacing
constrather thanletredo types
from
probably better to review with split diff
https://github.com/proposal-signals/proposal-signals/pull/97/files?diff=split