Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnbalanceDateDurationRelative: Return Date Duration Record but callers expect integer #2871

Closed
anba opened this issue Jun 3, 2024 · 0 comments · Fixed by #2896
Closed

UnbalanceDateDurationRelative: Return Date Duration Record but callers expect integer #2871

anba opened this issue Jun 3, 2024 · 0 comments · Fixed by #2896
Assignees
@ptomato
Labels
editorial spec-text Specification text involved
Milestone
Stage "3.5"

Comments

@anba
Copy link
Contributor

anba commented Jun 3, 2024

UnbalanceDateDurationRelative, step 6:

  1. Return ? CreateDateDurationRecord(0, 0, 0, days + yearsMonthsWeeksInDays).

It don't think callers require days + yearsMonthsWeeksInDays to represent valid duration days, so the step can most likely be changed to just:

  1. Return days + yearsMonthsWeeksInDays.
@ptomato ptomato self-assigned this Jun 5, 2024
@ptomato ptomato added spec-text Specification text involved editorial labels Jun 5, 2024
@ptomato ptomato added this to the Stage "3.5" milestone Jun 5, 2024
ptomato added a commit that referenced this issue Jun 13, 2024
@ptomato
Editorial: Fix returned value of UnbalanceDateDurationRelative
5207927 
This operation returns a number of days, not a Date Duration Record.

Closes: #2871
@ptomato ptomato mentioned this issue Jun 13, 2024
Merged
Ms2ger pushed a commit that referenced this issue Jun 14, 2024
@ptomato @Ms2ger
Editorial: Fix returned value of UnbalanceDateDurationRelative
96f3a01 
This operation returns a number of days, not a Date Duration Record.

Closes: #2871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
Stage "3.5"
Development

Successfully merging a pull request may close this issue.

Editorial: Batch of editorial improvements tc39/proposal-temporal
2 participants
@ptomato @anba