Editorial: Batch of editorial improvements #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds correct structured headers to all parsing operations, complete with definitions of Records used. The Records use ~empty~ instead of *undefined* to indicate absence of a particular element of the ISO string, which requires some changes in the calling operations to accommodate this. When returning ISO Date-Time Parse Records everywhere, ParseTemporalDateString becomes redundant.
…ding When calling DifferenceZonedDateTimeWithRounding with smallestUnit and largestUnit not the same unit, it's possible to hit the NudgeToZonedTime path, where [[Total]] is UNSET. This should be reflected in the structured header's return type. Closes: #2879
If the smallestUnit is a calendar unit, the largestUnit is also a calendar unit, so the check was redundant. However, keep it as an explicit assertion, for clarity to the reader. Closes: #2874
In 3 places the arguments were reversed. Closes: #2872
This operation returns a number of days, not a Date Duration Record. Closes: #2871
Ms2ger
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a batch of editorial fixes, including some docs improvements from Richard that I extracted out of another PR, and some of the newer editorial issues opened by Anba.
Best reviewed commit by commit.
Closes: #2871, #2872, #2874, #2875, #2879, #2887