Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DifferencePlainDateTimeWithRounding: Called with Temporal.PlainDate instead of separate arguments for year-month-day #2875

Closed
anba opened this issue Jun 3, 2024 · 1 comment
Closed

DifferencePlainDateTimeWithRounding: Called with Temporal.PlainDate instead of separate arguments for year-month-day #2875

anba opened this issue Jun 3, 2024 · 1 comment
Assignees
@ptomato
Labels
editorial spec-text Specification text involved
Milestone
Stage "3.5"

Comments

@anba
Copy link
Contributor

anba commented Jun 3, 2024

DifferencePlainDateTimeWithRounding's first argument should be changed from Temporal.PlainDate to separate integer arguments similar to y2, mon2, d2. This also allows to remove the unnecessary object allocation in DifferenceTemporalPlainDateTime.
@ptomato
Copy link
Collaborator

ptomato commented Jun 5, 2024

Oh, I completely missed that we no longer give that object to user code after @arshaw's optimizations. Thanks for catching it.

@ptomato ptomato self-assigned this Jun 5, 2024
@ptomato ptomato added spec-text Specification text involved editorial labels Jun 5, 2024
@ptomato ptomato added this to the Stage "3.5" milestone Jun 5, 2024
ptomato added a commit that referenced this issue Jun 13, 2024
@ptomato
Editorial: Pass year/month/day to DifferencePlainDateTimeWithRounding
d8a07e7 
Since #2758 we no longer need to keep this PlainDate object for passing to
calendar methods. This allows removing an unnecessary object creation that
implementations would be able to optimize out anyway because it's
unobservable.

Closes: #2875
@ptomato ptomato mentioned this issue Jun 13, 2024
Merged
@Ms2ger Ms2ger closed this as completed in 9ceb1bb Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
Stage "3.5"
Development

No branches or pull requests
2 participants
@ptomato @anba