Normative: Reject an ambiguous time string even with a calendar #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2287 +/- ##
==========================================
- Coverage 95.03% 95.02% -0.01%
==========================================
Files 20 20
Lines 10812 10817 +5
Branches 1927 1929 +2
==========================================
+ Hits 10275 10279 +4
- Misses 503 504 +1
Partials 34 34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ljharb
reviewed
Jun 10, 2022
This was referenced Aug 15, 2022
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Aug 16, 2022
This implements the normative change in tc39/proposal-temporal#2287 which reached consensus at the July 2022 TC39 meeting. It adds tests that ensure that PlainTime strings which require a T designator for disambiguation, are not disambiguated by adding a calendar annotation.
|
This gained consensus at the July 2022 TC39 plenary. Tests are now available in tc39/test262#3641. I had some last minute doubts about whether this one was actually correct, but I'm convinced by the discussion in #2285. |
ptomato
force-pushed
the
gh-2285-ambiguous-calendartime
branch
from
7bf3b3f
to
4a6f8c7
Compare
Ms2ger
pushed a commit
to ptomato/test262
that referenced
this pull request
Aug 31, 2022
This implements the normative change in tc39/proposal-temporal#2287 which reached consensus at the July 2022 TC39 meeting. It adds tests that ensure that PlainTime strings which require a T designator for disambiguation, are not disambiguated by adding a calendar annotation.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Aug 31, 2022
This implements the normative change in tc39/proposal-temporal#2287 which reached consensus at the July 2022 TC39 meeting. It adds tests that ensure that PlainTime strings which require a T designator for disambiguation, are not disambiguated by adding a calendar annotation.
ptomato
added a commit
to tc39/test262
that referenced
this pull request
Aug 31, 2022
This implements the normative change in tc39/proposal-temporal#2287 which reached consensus at the July 2022 TC39 meeting. It adds tests that ensure that PlainTime strings which require a T designator for disambiguation, are not disambiguated by adding a calendar annotation.
pull bot
pushed a commit
to jamlee-t/v8
that referenced
this pull request
Sep 10, 2022
Add TimeHourMinuteBasicFormatNotAmbiguousWithMonthDay TimeZoneNumericUTCOffsetNotAmbiguousWithDayOfMonth TimeZoneNumericUTCOffsetNotAmbiguousWithMonth TimeZoneIdentifier, UnpaddedHour, TimeZoneIANALegacyName productions. Sync the spec of TemporalInstantString, TemporalTimeString TimeZone, TimeZoneBracketedAnnotation, TemporalTimeZoneString, ToTemporalTimeZone, TimeZoneIANAName productions. Fix bug in ScanCalendarDateTimeTimeRequired, ToTemporalTimeZone Change name from Handle<String> to Handle<Object> to hold undefined Update parser tests accordingly. Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-iso8601grammar https://tc39.es/proposal-temporal/#sec-temporal-totemporaltimezone Related PR changes: tc39/proposal-temporal#2284 tc39/proposal-temporal#2287 tc39/proposal-temporal#2345 Bug: v8:11544 Change-Id: I6f1a5e5dedba461db9f36abe76fa97119c1f8c2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3822342 Reviewed-by: Shu-yu Guo <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/main@{#83123}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2285