Temporal: Add tests for PlainTime string disambiguation with time zone #3641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tacked tests for tc39/proposal-temporal#2287 onto this PR as well, since they are very similar. |
gibson042
previously approved these changes
Aug 17, 2022
...ate/prototype/toPlainDateTime/argument-string-time-designator-required-for-disambiguation.js
Outdated
Show resolved
Hide resolved
gibson042
previously approved these changes
Aug 17, 2022
...ate/prototype/toPlainDateTime/argument-string-time-designator-required-for-disambiguation.js
Outdated
Show resolved
Hide resolved
...ate/prototype/toPlainDateTime/argument-string-time-designator-required-for-disambiguation.js
Outdated
Show resolved
Hide resolved
Ms2ger
previously approved these changes
Aug 31, 2022
...ate/prototype/toPlainDateTime/argument-string-time-designator-required-for-disambiguation.js
Outdated
Show resolved
Hide resolved
...ate/prototype/toZonedDateTime/argument-string-time-designator-required-for-disambiguation.js
Outdated
Show resolved
Hide resolved
...eTime/prototype/withPlainTime/argument-string-time-designator-required-for-disambiguation.js
Outdated
Show resolved
Hide resolved
...al/PlainTime/prototype/equals/argument-string-time-designator-required-for-disambiguation.js
Outdated
Show resolved
Hide resolved
...ral/PlainTime/prototype/since/argument-string-time-designator-required-for-disambiguation.js
Outdated
Show resolved
Hide resolved
...ral/PlainTime/prototype/until/argument-string-time-designator-required-for-disambiguation.js
Outdated
Show resolved
Hide resolved
...eTime/prototype/withPlainTime/argument-string-time-designator-required-for-disambiguation.js
Outdated
Show resolved
Hide resolved
Ms2ger
previously approved these changes
Aug 31, 2022
This implements the normative change in tc39/proposal-temporal#2284 which reached consensus at the July 2022 TC39 meeting. It adds tests that ensure strings like HHMM-UU[TZ] and HHMMSS[TZ] do not require a disambiguating T separator, even if HHMM-UU and HHMMSS would by themselves.
This implements the normative change in tc39/proposal-temporal#2287 which reached consensus at the July 2022 TC39 meeting. It adds tests that ensure that PlainTime strings which require a T designator for disambiguation, are not disambiguated by adding a calendar annotation.
…ndar The strings with calendar annotations in these tests don't need to be listed separately, they can be derived from the original strings.
Ms2ger
previously approved these changes
Aug 31, 2022
…oralHelpers This adds an object, TemporalHelpers.ISO, which has methods that return arrays of various ISO strings. The idea is to deduplicate more string tests into methods on this object.
Ms2ger
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the normative change in
tc39/proposal-temporal#2284 which reached
consensus at the July 2022 TC39 meeting.
It adds tests that ensure strings like HHMM-UU[TZ] and HHMMSS[TZ] do not
require a disambiguating T separator, even if HHMM-UU and HHMMSS would by
themselves.