add missing Error.isError feature flag

See #4266 (comment)
tc39 · Oct 17, 2024 · 0645461 · 0645461
1 parent c54b89e
commit 0645461
Show file tree

Hide file tree

Showing 13 changed files with 16 additions and 6 deletions.
diff --git a/features.txt b/features.txt
@@ -80,6 +80,10 @@ uint8array-base64
 # https://github.com/tc39/proposal-atomics-microwait
 Atomics.pause
 
+# Error.isError
+# https://github.com/tc39/proposal-is-error
+Error.isError
+
 ## Standard language features
 #
 # Language features that have been included in a published version of the

diff --git a/test/built-ins/Error/isError/bigints.js b/test/built-ins/Error/isError/bigints.js
@@ -5,7 +5,7 @@
 esid: sec-error.iserror
 description: >
   Returns false on bigints
-features: [BigInt]
+features: [Error.isError, BigInt]
 ---*/
 
 assert.sameValue(Error.isError(0n), false);

diff --git a/test/built-ins/Error/isError/error-subclass.js b/test/built-ins/Error/isError/error-subclass.js
@@ -5,7 +5,7 @@
 esid: sec-error.iserror
 description: >
   Returns true on userland Error subclasses
-features: [class]
+features: [Error.isError, class]
 ---*/
 
 class MyError extends Error {}

diff --git a/test/built-ins/Error/isError/errors-other-realm.js b/test/built-ins/Error/isError/errors-other-realm.js
@@ -5,7 +5,7 @@
 esid: sec-error.iserror
 description: >
   Returns true on Error and Error subclass instances from a different realm
-features: [cross-realm]
+features: [Error.isError, cross-realm]
 ---*/
 
 var other = $262.createRealm().global;

diff --git a/test/built-ins/Error/isError/errors.js b/test/built-ins/Error/isError/errors.js
@@ -5,6 +5,7 @@
 esid: sec-error.iserror
 description: >
   Returns true on Error and Error subclass instances
+features: [Error.isError]
 ---*/
 
 assert.sameValue(Error.isError(new Error()), true);

diff --git a/test/built-ins/Error/isError/fake-errors.js b/test/built-ins/Error/isError/fake-errors.js
@@ -5,6 +5,7 @@
 esid: sec-error.iserror
 description: >
   Returns false on non-Error objects pretending to be an Error
+features: [Error.isError]
 ---*/
 
 var fakeError = {

diff --git a/test/built-ins/Error/isError/is-a-constructor.js b/test/built-ins/Error/isError/is-a-constructor.js
@@ -16,7 +16,7 @@ info: |
   If argument has a [[Construct]] internal method, return true.
   Return false.
 includes: [isConstructor.js]
-features: [Reflect.construct]
+features: [Error.isError, Reflect.construct]
 ---*/
 
 assert.sameValue(isConstructor(Error.isError), false, 'isConstructor(Error.isError) must return false');

diff --git a/test/built-ins/Error/isError/name.js b/test/built-ins/Error/isError/name.js
@@ -5,6 +5,7 @@
 esid: sec-error.iserror
 description: >
   The initial value of Error.isError.name is "isError".
+features: [Error.isError]
 ---*/
 
 assert.sameValue(Error.isError.name, 'isError');

diff --git a/test/built-ins/Error/isError/non-error-objects-other-realm.js b/test/built-ins/Error/isError/non-error-objects-other-realm.js
@@ -5,7 +5,7 @@
 esid: sec-error.iserror
 description: >
   Returns false on non-Error objects from a different realm
-features: [cross-realm]
+features: [Error.isError, cross-realm]
 ---*/
 
 var other = $262.createRealm().global;

diff --git a/test/built-ins/Error/isError/non-error-objects.js b/test/built-ins/Error/isError/non-error-objects.js
@@ -5,6 +5,7 @@
 esid: sec-error.iserror
 description: >
   Returns false on non-Error objects
+features: [Error.isError]
 ---*/
 
 assert.sameValue(Error.isError({}), false);

diff --git a/test/built-ins/Error/isError/primitives.js b/test/built-ins/Error/isError/primitives.js
@@ -5,6 +5,7 @@
 esid: sec-error.iserror
 description: >
   Returns false on primitives
+features: [Error.isError]
 ---*/
 
 assert.sameValue(Error.isError(), false);

diff --git a/test/built-ins/Error/isError/prop-desc.js b/test/built-ins/Error/isError/prop-desc.js
@@ -9,6 +9,7 @@ info: |
   has the attributes { [[Writable]]: true, [[Enumerable]]: false,
   [[Configurable]]: true } unless otherwise specified.
 includes: [propertyHelper.js]
+features: [Error.isError]
 ---*/
 
 verifyProperty(Error, "isError", {

diff --git a/test/built-ins/Error/isError/symbols.js b/test/built-ins/Error/isError/symbols.js
@@ -5,7 +5,7 @@
 esid: sec-error.iserror
 description: >
   Returns false on symbols
-features: [Symbol]
+features: [Error.isError, Symbol]
 ---*/
 
 assert.sameValue(Error.isError(new Symbol()), false);