Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Error.isError tests #4266

Merged
merged 1 commit into from
Oct 15, 2024
Merged

add Error.isError tests #4266

merged 1 commit into from
Oct 15, 2024

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Oct 15, 2024

@ljharb ljharb requested a review from a team as a code owner October 15, 2024 17:25
@ljharb ljharb mentioned this pull request Oct 9, 2024
Open
22 tasks
ptomato
ptomato approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but with s/assert.equal/assert.sameValue/g (or in the case of assert.equal(..., boolean) consider replacing with assert())

test/built-ins/Error/isError/is-a-constructor.js Outdated Show resolved Hide resolved
@ljharb
Copy link
Member Author

ljharb commented Oct 15, 2024

Thanks, updated (kept the explicit comparisons because i prefer them over implicit ones)

ptomato
ptomato approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptomato ptomato merged commit 4b17ad3 into main Oct 15, 2024
7 of 8 checks passed
@ptomato ptomato deleted the iserror branch October 15, 2024 18:12
@iamstolis
Copy link
Contributor

I think that these tests are missing a feature flag (for example, Error.isError).

@ptomato
Copy link
Contributor

ptomato commented Oct 17, 2024

I think that these tests are missing a feature flag (for example, Error.isError).

Thanks, but would you mind opening an issue (or a new PR if you have the time?) As a comment on a merged PR, it is likely to be missed.

@ljharb
Copy link
Member Author

ljharb commented Oct 17, 2024

whoops, thanks. i'll add one in a PR right now.

ljharb added a commit that referenced this pull request Oct 17, 2024
@ljharb
add missing Error.isError feature flag
796dfa5 
See #4266 (comment)
@ljharb ljharb mentioned this pull request Oct 17, 2024
Merged
@ljharb
Copy link
Member Author

ljharb commented Oct 17, 2024

→ #4271

ptomato pushed a commit that referenced this pull request Oct 17, 2024
@ljharb @ptomato
add missing Error.isError feature flag
0645461 
See #4266 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljharb @iamstolis @ptomato