New tests for Temporal.ZonedDateTime.p.toLocaleString #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
approved these changes
Apr 10, 2023
Comment on lines
+13
to
+14
| const {timeZone, ...options} = formatter.resolvedOptions(); | ||
| const datetime = new Temporal.ZonedDateTime(0n, timeZone); |
There was a problem hiding this comment.
Praise: Nice use of the spread operator to separate the time zone from the options
Ms2ger
approved these changes
Apr 11, 2023
In tc39/proposal-temporal#2522 which reached consensus at the March 2023 TC39 meeting, the functionality of Temporal.ZonedDateTime.p.toLocaleString was changed substantially, to not directly pass the ZonedDateTime to any Intl.DateTimeFormat methods. This adds rewrites of all existing tests for toLocaleString, as well as a few tests to verify that Intl.DateTimeFormat methods no longer support Temporal.ZonedDateTime arguments. As we are rewriting the tests anyway, this also ports all of the Temporal.ZonedDateTime.p.toLocaleString tests that were in staging, to the correct format for the main tree.
I wrote a similar test for Temporal.ZonedDateTime.p.toLocaleString, so while this was fresh I decided to do the same for the other toLocaleString calendar mismatch tests that were in staging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tc39/proposal-temporal#2522 which reached consensus at the March 2023 TC39 meeting, the functionality of Temporal.ZonedDateTime.p.toLocaleString was changed substantially, to not directly pass the ZonedDateTime to any Intl.DateTimeFormat methods. This adds rewrites of all existing tests for toLocaleString, as well as a few tests to verify that Intl.DateTimeFormat methods no longer support Temporal.ZonedDateTime arguments.
As we are rewriting the tests anyway, this also ports a bunch of toLocaleString tests that were in staging, to the correct format for the main tree.