Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tests for Temporal.ZonedDateTime.p.toLocaleString #3814

Merged
merged 2 commits into from
Apr 11, 2023
Merged

New tests for Temporal.ZonedDateTime.p.toLocaleString #3814

merged 2 commits into from
Apr 11, 2023

Commits on Apr 11, 2023

  1. Temporal: Rewrite Temporal.ZonedDateTime.p.toLocaleString tests 

    In tc39/proposal-temporal#2522 which reached
consensus at the March 2023 TC39 meeting, the functionality of
Temporal.ZonedDateTime.p.toLocaleString was changed substantially, to not
directly pass the ZonedDateTime to any Intl.DateTimeFormat methods. This
adds rewrites of all existing tests for toLocaleString, as well as a few
tests to verify that Intl.DateTimeFormat methods no longer support
Temporal.ZonedDateTime arguments.

As we are rewriting the tests anyway, this also ports all of the
Temporal.ZonedDateTime.p.toLocaleString tests that were in staging, to the
correct format for the main tree.
    @ptomato @Ms2ger
    ptomato authored and Ms2ger committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    7a84d76 View commit details
    Browse the repository at this point in the history

  2. Temporal: Port toLocaleString calendar mismatch tests from staging 

    I wrote a similar test for Temporal.ZonedDateTime.p.toLocaleString, so
while this was fresh I decided to do the same for the other toLocaleString
calendar mismatch tests that were in staging.
    @ptomato @Ms2ger
    ptomato authored and Ms2ger committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c338b41 View commit details
    Browse the repository at this point in the history